[desktop_webview_window] macos close webview process #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actually close webview when user calls `close()`, so window doesn't hang around longer than required
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a resource cleanup issue in the macOS desktop webview window implementation by ensuring the window is properly closed when the close() method is called, preventing windows from lingering unnecessarily.
- Adds explicit window closure call to the WebviewWindowController's cleanup process
Comment on lines
73
to
+74
| window?.delegate = nil | ||
| window?.close() |
There was a problem hiding this comment.
Consider calling window?.close() before setting window?.delegate = nil to ensure proper cleanup order. The delegate should remain active during the window closing process to handle any final window events.
Suggested change
| window?.delegate = nil | |
| window?.close() | |
| window?.close() | |
| window?.delegate = nil |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actually close webview when user calls
close(), so window doesn't hang around longer than required